-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(s2n-quic-core): implement nominal timers #2370
Conversation
d2e891c
to
73b5cc7
Compare
73b5cc7
to
d847e6d
Compare
dc/s2n-quic-dc/events/map.rs
Outdated
@@ -19,6 +19,9 @@ struct PathSecretMapUninitialized { | |||
/// The number of entries in the map | |||
#[measure("entries")] | |||
entries: usize, | |||
|
|||
#[measure("lifetime")] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to check, we auto-unit durations?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh we default to None
... lemme fix that. good catch!
I wonder if time since connection start is the right metric... Time since previous checkpoint might be more useful? Otherwise e.g. slow p100 on one phase will be hard to tell apart from sometimes slow across all the phases (when looking in aggregate) Essentially time in phase vs. time overall |
Hmm... I think it probably depends on what you're trying to do. For example, if you want to know average latency at which But I can definitely see another type of measurement that records "time since last update" |
Description of changes:
This change implements nominal timers for the aggregate metrics. It also adds a
checkpoint
andnominal_checkpoint
attribute to events, which allows them to record how long it took for the event to fire since the start of the connection.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.