feat: add fips aligned security policy without CBC #5265
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johubertj
changed the title
lrstewart
changed the title
lrstewart
added
the
do_not_merge
lrstewart
reviewed
May 8, 2025
There was a problem hiding this comment.
Can you use the "policy" utility in ./bin to generate a before and after report of the default_fips policy? A diff between the before and after would also help verify this change is correct.
Also, do you need to update the security policy documentation under ./docs?
lrstewart
reviewed
May 8, 2025
|
Oh, and this PR definitely needs a Release Notes section. And I'm also not sure why it doesn't have a Testing section. |
johubertj
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Summary:
security_policy_20250416that removes CBC cipher suites.Description of changes:
Removed CBC (Cipher Block Chaining) cipher suites due to their security weaknesses of being vulnerable to Padding Oracle Attacks.
Uses secure AEAD ciphers (immune to Padding Oracle Attacks), since AEAD ciphers don't have padding
Testing:
20250416to the list of policies being tested ins2n_security_policies_test.cBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.