-
Notifications
You must be signed in to change notification settings - Fork 1.2k
feat: Add support for MetricDefinitions in ModelTrainer #5202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5202 +/- ##
==========================================
+ Coverage 86.18% 86.19% +0.01%
==========================================
Files 446 446
Lines 43267 43277 +10
==========================================
+ Hits 37290 37304 +14
+ Misses 5977 5973 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mollyheamazon
approved these changes
Jun 12, 2025
rsareddy0329
approved these changes
Jun 12, 2025
Aditi2424
added a commit
that referenced
this pull request
Jun 23, 2025
* change: update jumpstart region_config, update image_uri_configs 06-12-2025 07:18:12 PST * feat: Add support for MetricDefinitions in ModelTrainer (#5202) * feat: Add support for MetricDefinitions in ModelTrainer * style fix * Update model_trainer.py to generate the doc * resolve unit test failed * solve another unit test error --------- Co-authored-by: Chad Chiang <[email protected]> * prepare release v2.247.0 * update development version to v2.247.1.dev0 * change: update image_uri_configs 06-19-2025 07:18:34 PST * prepare release v2.247.1 * update development version to v2.247.2.dev0 * documentation: update theme and add new pages * Add template files for custom logo and navbar --------- Co-authored-by: sagemaker-bot <[email protected]> Co-authored-by: Chad Chiang <[email protected]> Co-authored-by: Chad Chiang <[email protected]> Co-authored-by: ci <ci> Co-authored-by: adishaa <[email protected]>
Aditi2424
added a commit
that referenced
this pull request
Jun 23, 2025
* change: update jumpstart region_config, update image_uri_configs 06-12-2025 07:18:12 PST * feat: Add support for MetricDefinitions in ModelTrainer (#5202) * feat: Add support for MetricDefinitions in ModelTrainer * style fix * Update model_trainer.py to generate the doc * resolve unit test failed * solve another unit test error --------- Co-authored-by: Chad Chiang <[email protected]> * prepare release v2.247.0 * update development version to v2.247.1.dev0 * change: update image_uri_configs 06-19-2025 07:18:34 PST * prepare release v2.247.1 * update development version to v2.247.2.dev0 * change: relax protobuf to <6.32 (#5211) --------- Co-authored-by: sagemaker-bot <[email protected]> Co-authored-by: Chad Chiang <[email protected]> Co-authored-by: Chad Chiang <[email protected]> Co-authored-by: ci <ci> Co-authored-by: parknate@ <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Issue: #5018
Description of changes:
Testing done:
Merge Checklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
unique_name_from_base
to create resource names in integ tests (if appropriate)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.