Skip to content

Conversation

@valerena
Copy link
Contributor

When we have new features, cfn-lint might not have support to all those features yet, so we usually just ignore some test files until that's supported.. but then we rarely actually remove that so those test files just remain ignored in cfn-lint forever. So this is an overall cleanup to remove all the ignores that are not needed.

The next step would be to confirm why all these files are ignored, and eventually fix some that make sense to fix (except the ones that have some errors on purpose).

Issue #, if available

Description of changes

Description of how you validated changes

Checklist

Examples?

Please reach out in the comments if you want to add an example. Examples will be
added to sam init through aws/aws-sam-cli-app-templates.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

When we have new features, cfn-lint might not have support to all those
features yet, so we usually just ignore some files until that's supported
but then we rarely actually remove that so the files just remain ignored
forever. So this is an overall cleanup to remove all the ignores that are
not needed.

The next step would be to confirm why all these files are ignored, and
eventually fix some that make sense to fix (some have errors on purpose).
@valerena valerena requested a review from a team as a code owner December 15, 2025 21:15
@vicheey
Copy link
Contributor

vicheey commented Dec 15, 2025

I assume you ran samdev validate --lint with the changes and succeed, correct?

@valerena
Copy link
Contributor Author

I assume you ran samdev validate --lint with the changes and succeed, correct?

I didn't use SAM CLI. But here in the SAM-T repo I ran make pr, which runs cfn-lint on all the tests files

@valerena valerena merged commit b89c691 into aws:develop Dec 15, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants