Added Async Python SDK Config #183
Conversation
| @@ -295,6 +295,16 @@ Python: | |||
| api_ref: | |||
| uid: "boto3" | |||
| name: "&guide-python3-api;" | |||
| 301: | |||
There was a problem hiding this comment.
Various questions:
- Why 301 and not 4?
- Entities must be defined and I don't think these are.
- Is "SDK for Python Async" the official name?
- api_ref defaults to goto links, which will fail for this. Use a
link_templateinstead.
There was a problem hiding this comment.
The SDK doesn't have an official name yet. We're currently referring to it as the Async SDK for Python, but it's a placeholder.
There was a problem hiding this comment.
The most important thing to keep in mind in all decision-making is that this is a new SDK, not a new version of an existing one.
| @@ -295,6 +295,16 @@ Python: | |||
| api_ref: | |||
| uid: "boto3" | |||
| name: "&guide-python3-api;" | |||
| 301: | |||
| long: "&Python301long;" | |||
There was a problem hiding this comment.
I think the entities should be &PythonAsynclong; and so forth.
There was a problem hiding this comment.
Hi, I have updated entity names in the latest commit.
| expanded: | ||
| long: "AWS SDK for Python Async" | ||
| short: "SDK for Python Async" | ||
| guide: "https://github.com/awslabs/aws-sdk-python" |
There was a problem hiding this comment.
The guide is currently at https://github.com/awslabs/aws-sdk-python/blob/develop/dev-guide/index.md. It will move to the docs site when we add the next service to the SDK sometime late in the summer or early in the autumn.
There was a problem hiding this comment.
I have updated the guide link in the latest commit.
| long: "&Python301long;" | ||
| short: "&Python301;" | ||
| long: "&PythonAsynclong;" | ||
| short: "&PythonAsync;" | ||
| expanded: | ||
| long: "AWS SDK for Python Async" |
There was a problem hiding this comment.
These names should be "Async AWS SDK for Python" and "Async SDK for Python" (in my opinion). Of course, they're likely to change later anyway, but that's my thinking on it. Other than this, these changes LGTM.
| @@ -296,12 +296,12 @@ Python: | |||
| uid: "boto3" | |||
| name: "&guide-python3-api;" | |||
| 301: | |||
| long: "&Python301long;" | |||
| short: "&Python301;" | |||
| long: "&PythonAsynclong;" | |||
There was a problem hiding this comment.
In order for these entities to resolve to something they must be define in the local phrases-code-examples.ent file in this repo. (and later in the global internal shared entities file around GA time)
I have added config for the Async Python SDK.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.