Feat: Request Hedging Tool#47 implementation #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update logging levels
Logging pattern optimized for small size
- Add ddb.hedging.number config to control concurrent requests - Create MultiHedgingRequestHandler for parallel request handling - Integrate hedging support in request pipeline
- Added support for Netty Http client - MultiHedgingRequestHandler changes to use Netty eventloop.
Implemented the hedging demo using Java SDK 2.0
tebanieo
requested changes
Feb 3, 2025
ddb-hedging/README.md
Outdated
There was a problem hiding this comment.
Please include one section that explains how does the sample table looks like and how you run the test as specified in ddb-hedging/src/test/java/com/dynamodbdemo/GenerateLoadTestData.java
There was a problem hiding this comment.
Please add a readme that explains how to use this yml file. It would be nice to include a sample execution in either video or gif.
|
|
||
| private static final Logger logger = LoggerFactory.getLogger(DynamoDbConfig.class); | ||
|
|
||
| @Value("${aws.dynamodb.region}") |
There was a problem hiding this comment.
Should you add a validation?
@PostConstruct
public void validateConfiguration() {
Assert.isTrue(connectionTimeoutSeconds > 0, "Connection timeout must be positive");
Assert.isTrue(apiTimeoutSeconds > 0, "API timeout must be positive");
Assert.isTrue(maxConcurrency > 0, "Max concurrency must be positive");
Assert.hasText(region, "Region must not be empty");
}
| @Bean(name = "DDBAsyncClient") | ||
| @ConditionalOnProperty(name = "aws.dynamodb.use-crt-client", havingValue = "false") | ||
| public DynamoDbAsyncClient getNettyDynamoDbAsyncClient(SdkEventLoopGroup eventLoopGroup) { | ||
| if (dynamoDbAsyncClient == null) { |
There was a problem hiding this comment.
This might be a double-check but can you use the synchronized (xxx.class) {} for extra thread safety? (there was another place, I believe at the logs as well).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #47
Description:
This PR provides an DynamoDB request hedging functionality for AWS SDK for Java 2.x.
Key features:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.