-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to JDK17. #2342
base: master
Are you sure you want to change the base?
Upgrade to JDK17. #2342
Conversation
41ac014
to
829112e
Compare
829112e
to
b349377
Compare
Thanks @VenkatasivareddyTR; can you check on the build error, please:
|
@macohen The build process appears to be running on JDK 11. To align with the codebase, we need to update the build environment to use JDK 17. |
fb69b22
to
f99d706
Compare
1e45563
to
33975a3
Compare
the code looks fine, but the GH actions are breaking and won't work until we're building with JDK 17 it seems. Is that right? are you able to update the actions (I know this build still won't pass until those are merged)... |
Yes correct, we would need to update the GH actions with JDK 17 to build this PR successfully. We have tested this in our local environments with JDK 17 setup. To update the GH actions to take JDK 17, we are updating the respective YAML files (in .github/workflows/). We will be testing it in a fork before raising the PR for the same. |
33975a3
to
459234f
Compare
095feec
to
975ff59
Compare
PR for GitHub Actions update for java 17. |
Issue #, if available:
#2295
Description of changes:
Upgrade to JDK 17.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.