Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to JDK17. #2342

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

VenkatasivareddyTR
Copy link
Contributor

@VenkatasivareddyTR VenkatasivareddyTR commented Oct 18, 2024

Issue #, if available:
#2295
Description of changes:
Upgrade to JDK 17.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@Jithendar12 Jithendar12 force-pushed the feature/upgrade_jdk17 branch 3 times, most recently from 41ac014 to 829112e Compare October 22, 2024 12:55
@VenkatasivareddyTR VenkatasivareddyTR marked this pull request as ready for review October 22, 2024 13:27
@VenkatasivareddyTR VenkatasivareddyTR changed the title Upgrade to JDK17 initial commit. Upgrade to JDK17. Oct 23, 2024
@macohen
Copy link
Contributor

macohen commented Oct 23, 2024

Thanks @VenkatasivareddyTR; can you check on the build error, please:

Error:  Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.13.0:compile (default-compile) on project aws-athena-federation-sdk: Fatal error compiling: error: release version 17 not supported -> [Help 1]

https://github.com/awslabs/aws-athena-query-federation/actions/runs/11475342726/job/31973995753?pr=2342

@VenkatasivareddyTR
Copy link
Contributor Author

@macohen The build process appears to be running on JDK 11. To align with the codebase, we need to update the build environment to use JDK 17.

@Jithendar12 Jithendar12 force-pushed the feature/upgrade_jdk17 branch 3 times, most recently from fb69b22 to f99d706 Compare October 25, 2024 11:35
@Jithendar12 Jithendar12 force-pushed the feature/upgrade_jdk17 branch 2 times, most recently from 1e45563 to 33975a3 Compare October 30, 2024 08:01
@macohen
Copy link
Contributor

macohen commented Oct 31, 2024

the code looks fine, but the GH actions are breaking and won't work until we're building with JDK 17 it seems. Is that right? are you able to update the actions (I know this build still won't pass until those are merged)...

@abhishekpoddar-trianz
Copy link

Yes correct, we would need to update the GH actions with JDK 17 to build this PR successfully. We have tested this in our local environments with JDK 17 setup.

To update the GH actions to take JDK 17, we are updating the respective YAML files (in .github/workflows/). We will be testing it in a fork before raising the PR for the same.

@abhishekpoddar-trianz
Copy link

PR for GitHub Actions update for java 17.
#2377

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants