Fix issue with secret being not populated for default EnvironmentProp… #2393
+7
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ejeffrli
force-pushed
the
panama-elasticsearch-fix
branch
from
1bde417
to
81a46c2
Compare
aimethed
approved these changes
Nov 14, 2024
macohen
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…erties behavior
Issue #, if available:
Previously, authenticationConfigurationToMap would correctly populate secret_name. However, the output gets passed to connectionPropertiesToEnvironment(...) which returned an empty hashmap. This empty hashmap would mean secret_name did not exist in config map.
Description of changes:
connectionPropertiesToEnvironment default behavior is now to keep all glue ConnectionProperties + authentication configuration fields in environment unless connectionPropertiesToEnvironment is overriden (It is commonly overriden by jdbc connectors and bigquery for example).
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.