Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(spec): Duvet's Specificaiton #63

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

texastony
Copy link
Contributor

Issue #, if available: Duvet Needs a Specification

Description of changes:
Adds specs, a directory holding:

  • A Specification,
    describing the purpose and behavior of Duvet,
    written as duvet-specification.md.

  • A README.md,
    describing the purpose of the Specification,
    the style conventions followed by it,
    and how to use the continuous integration (ci) test and
    extraction utilities.

  • A directory ci,
    holding bash script to prettify the markdown spec.

  • Some config files for prettify

  • A directory util,
    holding a node and bash scripts to transform the
    markdown spec to an RFC text and TOML files that
    the current version of Duvet can then work with.

Testing: CI:

❯ ./ci/prettify.sh check
Checking formatting...
All matched files use Prettier code style!

Replaces #61

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@texastony texastony requested a review from seebees August 19, 2022 23:44
@texastony texastony requested review from camshaft and a team as code owners August 19, 2022 23:44
specs/duvet-specification.md Show resolved Hide resolved
specs/duvet-specification.md Outdated Show resolved Hide resolved
specs/duvet-specification.md Outdated Show resolved Hide resolved
specs/duvet-specification.md Outdated Show resolved Hide resolved
specs/duvet-specification.md Outdated Show resolved Hide resolved
specs/duvet-specification.md Outdated Show resolved Hide resolved
and MUST identify the specification that contains this section and content.
The URL MUST contain a URL fragment that uniquely identifies
the section that contains this content.
If the URL only contains a URL fragment
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a bit underspecified to me. What is the scope of the fragment? Should it be limited to a single package? A single repo? Dependencies included? Global? I think we also need to define what it means for "Duvet to manage implementation specific requirements"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When you say "scope" what do you mean?
If you have a specification that defines a requirement for any of these scopes what do you do?
As I understand it the scope is resolved by the scope of files you feed into duvet.
Currently if you annotate 3 specifications
and feed all these source files but only 2 specs into duvet it gets quite upset.

So I see this as a simple short hand to work around building a TOML file.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

took a stab

specs/duvet-specification.md Outdated Show resolved Hide resolved
specs/duvet-specification.md Outdated Show resolved Hide resolved
specs/duvet-specification.md Show resolved Hide resolved
Co-authored-by: Cameron Bytheway <[email protected]>
texastony and others added 3 commits September 27, 2022 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants