Updates to the JS Report #96
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make the report use the entier browser. Also change the text and section columns to autoresize
The value getter for section should return the string, not the whole row.
It can be useful to view all requriements across every specification.
camshaft
reviewed
Nov 19, 2022
www/src/App.js
Outdated
Comment on lines
145
to
157
| const requirements = specifications.flatMap((spec) => spec.requirements); | ||
| const total = { | ||
| id: "AllSpecifications", | ||
| stats: specifications.reduce((total, {stats}) => { | ||
| Object.keys(stats).forEach((statName) => { | ||
| const stat = total[statName] || new StatsClass() | ||
| total[statName] = stat; | ||
| stat.onStat(stats[statName]); | ||
| }); | ||
| return total; | ||
| }, {}), | ||
| requirements, | ||
| } |
There was a problem hiding this comment.
Can you move this to result.js so that we're not recomputing stats every time you load this page? Or at least cache the value.
There was a problem hiding this comment.
Sure, it is not a lot of work and everything is local,
so I was not too worried, but :)
www/src/App.js
Outdated
Comment on lines
158
to
159
| specifications | ||
| .map((spec) => spec.requirements) |
www/src/stats_class.js
Outdated
| @@ -0,0 +1,46 @@ | |||
|
|
|||
There was a problem hiding this comment.
nit: just call this file stats.js
www/src/App.js
Outdated
| import specifications from "./result"; | ||
| import { Stats as StatsClass } from "./stats_class"; |
There was a problem hiding this comment.
nit: Why does the name need Class at the end?
There was a problem hiding this comment.
Line 7 import Stats from "./spec"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enlarging the DataGrid to use the entire browser.
Changing the section and text column to use all available width.
Fix filtering by section
Add a requirements view that lists all requirements across all specifications.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.