Skip to content

Conversation

wakariyasuku
Copy link

What does this PR do?

Fixes the OKTA secrets creation script to properly handle environment variables that contain values wrapped in double quotes.

Motivation

When users set OKTA environment variables with quoted values (e.g., OKTA_CLIENT_ID="value"), the script generates malformed JSON with double-escaped quotes, causing ECS tasks to fail during secret retrieval.

Fixes #176

Changes

  • Added sed commands to strip surrounding double quotes from OKTA environment variables before JSON generation
  • Ensures compatibility with both quoted and unquoted environment variable values

For Moderators

  • Compile, build, tests successful before merge?

Additional Notes

This fix specifically addresses the OKTA section where the issue was reported. The fix has been tested with both quoted and unquoted environment variable values.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix double quote escaping in OKTA secrets creation script
1 participant