-
Notifications
You must be signed in to change notification settings - Fork 5
feat: Multi-modal payload support, binary-safe serialization, and cross-platform file operations #40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
acere
wants to merge
8
commits into
awslabs:main
Choose a base branch
from
acere:fix/image-payload-serialization
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: Multi-modal payload support, binary-safe serialization, and cross-platform file operations #40
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
3c91762
Fix image payload serialization to avoid base64 encoding overhead
acere 39baca7
feat(multimodal): Add comprehensive multi-modal payload support acros…
acere 7a64e10
refactor: Standardize file operations to use UPath for cross-platform…
acere e0ecacb
fix: serialize datetime fields in Result.to_dict for JSON-safe stats
acere 4f2e79a
refactor: replace os.PathLike with UPath type aliases and add ensure_…
acere 964ac45
fix: extend os.PathLike isinstance checks to also catch cloud UPath i…
acere a263977
refactor: consolidate serialization into llmeter/json_utils.py
acere 10558db
refactor: remove premature type coercion from to_dict methods
acere File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| :::: llmeter.json_utils |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,8 +1,10 @@ | ||
| # Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved. | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
| # Python Built-Ins: | ||
| from dataclasses import dataclass, field | ||
| import importlib | ||
| from dataclasses import dataclass, field | ||
|
|
||
| from llmeter.utils import ensure_path | ||
|
|
||
| # Local Dependencies: | ||
| from ...endpoints.base import InvocationResponse | ||
|
|
@@ -11,7 +13,7 @@ | |
| from ..base import Callback | ||
| from .dimensions import IRequestCostDimension, IRunCostDimension | ||
| from .results import CalculatedCostWithDimensions | ||
| from .serde import from_dict_with_class_map, JSONableBase | ||
| from .serde import JSONableBase, from_dict_with_class_map | ||
|
|
||
|
|
||
| @dataclass | ||
|
|
@@ -201,7 +203,9 @@ async def after_run(self, result: Result) -> None: | |
|
|
||
| def save_to_file(self, path: str) -> None: | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think this |
||
| """Save the cost model (including all dimensions) to a JSON file""" | ||
| with open(path, "w") as f: | ||
| path = ensure_path(path) | ||
| path.parent.mkdir(parents=True, exist_ok=True) | ||
| with path.open("w") as f: | ||
| f.write(self.to_json()) | ||
|
|
||
| @classmethod | ||
|
|
@@ -222,5 +226,6 @@ def from_dict(cls, raw: dict, alt_classes: dict = {}, **kwargs) -> "CostModel": | |
| @classmethod | ||
| def _load_from_file(cls, path: str): | ||
| """Load the cost model (including all dimensions) from a JSON file""" | ||
| with open(path, "r") as f: | ||
| path = ensure_path(path) | ||
| with path.open("r") as f: | ||
| return cls.from_json(f.read()) | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not necessarily a problem to solve for the entire codebase here, but this is mixing absolute & local relative imports (see local dependencies section below).
As discussed I think we prefer to standardize on relative, so let's at least ensure we're not introducing new absolute imports in this PR.