Remove 16MiB part size override in FIO read benchmarks #1101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Carl Jones <[email protected]>
dannycjones
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
dannycjones
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
dannycjones
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
dannycjones
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
dannycjones
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
dannycjones
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
dannycjones
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
dannycjones
temporarily deployed
to
PR benchmarks
GitHub Actions
Inactive
dannycjones
temporarily deployed
to
PR benchmarks
GitHub Actions
Inactive
dannycjones
temporarily deployed
to
PR benchmarks
GitHub Actions
Inactive
dannycjones
temporarily deployed
to
PR benchmarks
GitHub Actions
Inactive
dannycjones
temporarily deployed
to
PR benchmarks
GitHub Actions
Inactive
|
Some context here: likely this was updated to use 16MiB so we can upload 100GiB files. I've moved to draft so that we can address this before merging. |
|
I am working on a refactoring in this bit of code: one thing to watch out for is that the file layout will fail for the 100GB files if the part size isn't large enough. EDIT: wrote that before I saw your comment above. That will be an issue for sure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
The read benchmarks currently override the part size. It's unclear why this was added (#779), but we think its best to remove the override such that the benchmarks represent the default configuration.
Relevant issues: N/A
Does this change impact existing behavior?
It changes benchmark configuration. We expect the effect to be minimal.
No impact to Mountpoint itself.
Does this change need a changelog entry in any of the crates?
No.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the Developer Certificate of Origin (DCO).