Add a test for an invalid cache block #1139
Open
+149
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vlad Volodkin <[email protected]>
vladem
requested a deployment
to
PR integration tests
GitHub Actions
Waiting
vladem
requested a deployment
to
PR integration tests
GitHub Actions
Waiting
vladem
requested a deployment
to
PR integration tests
GitHub Actions
Waiting
vladem
requested a deployment
to
PR integration tests
GitHub Actions
Waiting
vladem
requested a deployment
to
PR integration tests
GitHub Actions
Waiting
vladem
requested a deployment
to
PR integration tests
GitHub Actions
Waiting
vladem
requested a deployment
to
PR integration tests
GitHub Actions
Waiting
Signed-off-by: Vlad Volodkin <[email protected]>
vladem
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
vladem
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
vladem
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
vladem
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
vladem
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
vladem
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
passaro
reviewed
Nov 14, 2024
| let (mount_point, _session) = mount_bucket(client, cache.clone(), &bucket, &prefix); | ||
|
|
||
| // Put an object to the mounted bucket | ||
| let bucket_client = create_test_client(®ion, &bucket, &prefix); |
There was a problem hiding this comment.
Is there a reason to use TestClient here? Why not just use an S3 client directly? This test would be much simpler and no need to add the get_object_etag method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Just adds a test that if a block in the shared cache is invalid, it is not served to the client application.
Relevant issues: N/A
Does this change impact existing behavior?
No.
Does this change need a changelog entry in any of the crates?
No.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the Developer Certificate of Origin (DCO).