Fix directional light shadows: take two #181
Merged
+286
−117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR aims to do the same as awtterpip#180, but hopefully without making future WebXR compat more annoying. get_frustum_corners() is now implemented properly, directly from the projection matrix. I believe it should work with the existing OpenXR code, but I cannot test this with any WebXR implementations with "sheared projection matrices", because I am continuing to doubt whether that even exists. I also added unit tests, which involved a decent amount of code shuffling regardless. The original implementation from awtterpip#180 is left in as a control in the test code.
Comment on lines
+85
to
+88
| // I don't know why multiplying the Z axis by -1 is necessary. | ||
| // As far as I can tell from (likely my incorrect understanding of the code), | ||
| // PerspectiveProjection::get_frustum_corners() has the Z axis inverted?? | ||
| Vec3A::from_vec4(inverse_matrix.mul_vec4(clip_pos)) / near * Vec3A::new(1., 1., -1.) |
There was a problem hiding this comment.
Is this related to infinite far plane (far_z <= near_z)?
There was a problem hiding this comment.
No, the reverse Z only flips the resulting depth in the range 0-1. It should still have a right-handed coordinate system with Z- forward, but the existing bevy math writes the resulting frustum as if it's in the Z+ space.
|
Well, it works. |
|
LGTM let me know if you are okay with me merging thus in its current state |
Yep, I think it's done. Except maybe figuring out what's up with the coordinate space flip thing but idk. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to do the same as #180, but hopefully without making future WebXR compat more annoying.
get_frustum_corners() is now implemented properly, directly from the projection matrix. I believe it should work with the existing OpenXR code, but I cannot test this with any WebXR implementations with "sheared projection matrices", because I am continuing to doubt whether that even exists.
I also added unit tests, which involved a decent amount of code shuffling regardless. The original implementation from #180 is left in as a control in the test code.
Fixes #179