Implementation of the Brazilian Portuguese Language #1283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement pt-br model
|
Kudos, SonarCloud Quality Gate passed!
|
ericzon
reviewed
May 25, 2023
packages/language/src/languages.json
Outdated
| [["aa","aar","Afar"],["ab","abk","Abkhazian"],["af","afr","Afrikaans"],["ak","aka","Akan"],["am","amh","Amharic"],["ar","arb","Arabic"],["an","arg","Aragonese"],["as","asm","Assamese"],["av","ava","Avaric"],["ae","ave","Avestan"],["ay","aym","Aymara"],["az","aze","Azerbaijani"],["ba","bak","Bashkir"],["bm","bam","Bambara"],["be","bel","Belarusian"],["bn","ben","Bengali"],["bh","bih","Bihari languages"],["bi","bis","Bislama"],["bo","bod","Tibetan"],["bs","bos","Bosnian"],["br","bre","Breton"],["bg","bul","Bulgarian"],["ca","cat","Catalan"],["cs","ces","Czech"],["ch","cha","Chamorro"],["ce","che","Chechen"],["cu","chu","Church Slavic"],["cv","chv","Chuvash"],["kw","cor","Cornish"],["co","cos","Corsican"],["cr","cre","Cree"],["cy","cym","Welsh"],["da","dan","Danish"],["de","deu","German"],["dv","div","Divehi"],["dz","dzo","Dzongkha"],["el","ell","Greek"],["en","eng","English"],["eo","epo","Esperanto"],["et","est","Estonian"],["eu","eus","Basque"],["ee","ewe","Ewe"],["fo","fao","Faroese"],["fa","fas","Persian"],["fj","fij","Fijian"],["fi","fin","Finnish"],["fr","fra","French"],["fy","fry","Western Frisian"],["ff","ful","Fulah"],["gd","gla","Gaelic"],["ga","gle","Irish"],["gl","glg","Galician"],["gv","glv","Manx"],["gn","grn","Guarani"],["gu","guj","Gujarati"],["ht","hat","Haitian"],["ha","hau","Hausa"],["he","heb","Hebrew"],["hz","her","Herero"],["hi","hin","Hindi"],["ho","hmo","Hiri Motu"],["hr","hrv","Croatian"],["hu","hun","Hungarian"],["hy","hye","Armenian"],["ig","ibo","Igbo"],["io","ido","Ido"],["ii","iii","Sichuan Yi"],["iu","iku","Inuktitut"],["ie","ile","Interlingue"],["ia","ina","Interlingua"],["id","ind","Indonesian"],["ik","ipk","Inupiaq"],["is","isl","Icelandic"],["it","ita","Italian"],["jv","jav","Javanese"],["ja","jpn","Japanese"],["kl","kal","Kalaallisut"],["kn","kan","Kannada"],["ks","kas","Kashmiri"],["ka","kat","Georgian"],["kr","kau","Kanuri"],["kk","kaz","Kazakh"],["km","khm","Central Khmer"],["ki","kik","Kikuyu"],["rw","kin","Kinyarwanda"],["ky","kir","Kirghiz"],["kv","kom","Komi"],["kg","kon","Kongo"],["ko","kor","Korean"],["kj","kua","Kuanyama"],["ku","kur","Kurdish"],["lo","lao","Lao"],["la","lat","Latin"],["lv","lav","Latvian"],["li","lim","Limburgan"],["ln","lin","Lingala"],["lt","lit","Lithuanian"],["lb","ltz","Luxembourgish"],["lu","lub","Luba-Katanga"],["lg","lug","Ganda"],["mh","mah","Marshallese"],["ml","mal","Malayalam"],["mr","mar","Marathi"],["mk","mkd","Macedonian"],["mg","mlg","Malagasy"],["mt","mlt","Maltese"],["mn","mon","Mongolian"],["mi","mri","Maori"],["ms","msa","Malay"],["my","mya","Burmese"],["na","nau","Nauru"],["nv","nav","Navajo"],["nr","nbl","Ndebele, South"],["nd","nde","Ndebele, North"],["ng","ndo","Ndonga"],["ne","nep","Nepali"],["nl","nld","Dutch"],["nn","nno","Norwegian Nynorsk"],["nb","nob","Bokmål, Norwegian"],["no","nor","Norwegian"],["ny","nya","Chichewa"],["oc","oci","Occitan"],["oj","oji","Ojibwa"],["or","ori","Oriya"],["om","orm","Oromo"],["os","oss","Ossetian"],["pa","pan","Panjabi"],["pi","pli","Pali"],["pl","pol","Polish"],["pt","por","Portuguese"],["br","por","Brazilian Portuguese"],["ps","pus","Pushto"],["qu","que","Quechua"],["rm","roh","Romansh"],["ro","ron","Romanian"],["rn","run","Rundi"],["ru","rus","Russian"],["sg","sag","Sango"],["sa","san","Sanskrit"],["si","sin","Sinhala"],["sk","slk","Slovak"],["sl","slv","Slovenian"],["se","sme","Northern Sami"],["sm","smo","Samoan"],["sn","sna","Shona"],["sd","snd","Sindhi"],["so","som","Somali"],["st","sot","Sotho, Southern"],["es","spa","Spanish"],["sq","sqi","Albanian"],["sc","srd","Sardinian"],["sr","srp","Serbian"],["ss","ssw","Swati"],["su","sun","Sundanese"],["sw","swa","Swahili"],["sv","swe","Swedish"],["ty","tah","Tahitian"],["ta","tam","Tamil"],["tt","tat","Tatar"],["te","tel","Telugu"],["tg","tgk","Tajik"],["tl","tgl","Tagalog"],["th","tha","Thai"],["ti","tir","Tigrinya"],["to","ton","Tonga"],["tn","tsn","Tswana"],["ts","tso","Tsonga"],["tk","tuk","Turkmen"],["tr","tur","Turkish"],["tw","twi","Twi"],["ug","uig","Uighur"],["uk","ukr","Ukrainian"],["ur","urd","Urdu"],["uz","uzb","Uzbek"],["ve","ven","Venda"],["vi","vie","Vietnamese"],["vo","vol","Volapük"],["wa","wln","Walloon"],["wo","wol","Wolof"],["xh","xho","Xhosa"],["yi","yid","Yiddish"],["yo","yor","Yoruba"],["za","zha","Zhuang"],["zh","cmn","Chinese"],["zu","zul","Zulu"]] |
There was a problem hiding this comment.
I see here
["br","bre","Breton"]and
["br","por","Brazilian Portuguese"]this can drive to a collision in cases like
this.languagesAlpha2[language.alpha2] = language;There was a problem hiding this comment.
I understand, but we have a small problem, in this case you use ISO 639-2 and I couldn't find Brazilian Portuguese in this ISO.
My suggestion would be to change from:
["br","por","Brazilian Portuguese"]
For:
["pt-BR","por","Brazilian Portuguese"]
In this case, we would use the IETF https://en.wikipedia.org/wiki/IETF_language_tag.
ericzon
requested changes
May 25, 2023
|
SonarCloud Quality Gate failed.
|
|
any updates? |
|
After implementing the change to pt-BR for Brazilian Portuguese, I conducted thorough tests. Since the alpha2 code is now unique, no collisions or related bugs were identified. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of the Brazilian Portuguese Language
PR Checklist
npm testlocally and all tests are passing.PR Description
Hey guys. All good?
I come here to add my contribution to the Brazilian Portuguese language. I created a new folder inside packages for this.
I'm available for any questions!