chore: use string.concat for string combination instead

axieinfinity · Jan 2, 2024 · 0e00588 · 0e00588
1 parent 1af4175
commit 0e00588
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 27 deletions.
diff --git a/src/legacy/transfers/RONTransferHelper.sol b/src/legacy/transfers/RONTransferHelper.sol
@@ -15,13 +15,11 @@ library RONTransferHelper {
 
     if (!success) {
       revert(
-        string(
-          abi.encodePacked(
-            "TransferHelper: could not transfer RON to ",
-            Strings.toHexString(uint160(address(to)), 20),
-            " value ",
-            Strings.toHexString(value)
-          )
+        string.concat(
+          "TransferHelper: could not transfer RON to ",
+          Strings.toHexString(uint160(address(to)), 20),
+          " value ",
+          Strings.toHexString(value)
         )
       );
     }

diff --git a/src/legacy/transfers/TransferFromHelper.sol b/src/legacy/transfers/TransferFromHelper.sol
@@ -23,17 +23,15 @@ library TransferFromHelper {
 
     if (!success || !(data.length == 0 || abi.decode(data, (bool)))) {
       revert(
-        string(
-          abi.encodePacked(
-            "TransferFromHelper: could not transfer token ",
-            Strings.toHexString(uint160(token), 20),
-            " from ",
-            Strings.toHexString(uint160(from), 20),
-            " to ",
-            Strings.toHexString(uint160(to), 20),
-            " value ",
-            Strings.toHexString(value)
-          )
+        string.concat(
+          "TransferFromHelper: could not transfer token ",
+          Strings.toHexString(uint160(token), 20),
+          " from ",
+          Strings.toHexString(uint160(from), 20),
+          " to ",
+          Strings.toHexString(uint160(to), 20),
+          " value ",
+          Strings.toHexString(value)
         )
       );
     }

diff --git a/src/legacy/transfers/TransferHelper.sol b/src/legacy/transfers/TransferHelper.sol
@@ -22,15 +22,13 @@ library TransferHelper {
 
     if (!success || !(data.length == 0 || abi.decode(data, (bool)))) {
       revert(
-        string(
-          abi.encodePacked(
-            "TransferHelper: could not transfer token ",
-            Strings.toHexString(uint160(token), 20),
-            " to ",
-            Strings.toHexString(uint160(to), 20),
-            " value ",
-            Strings.toHexString(value)
-          )
+        string.concat(
+          "TransferHelper: could not transfer token ",
+          Strings.toHexString(uint160(token), 20),
+          " to ",
+          Strings.toHexString(uint160(to), 20),
+          " value ",
+          Strings.toHexString(value)
         )
       );
     }