Skip to content

Fix DICOM viewer for public shares#149

Open
loxK wants to merge 1 commit intoayselafsar:masterfrom
Gecka-Apps:fix-public-share
Open

Fix DICOM viewer for public shares#149
loxK wants to merge 1 commit intoayselafsar:masterfrom
Gecka-Apps:fix-public-share

Conversation

@loxK
Copy link
Copy Markdown

@loxK loxK commented Oct 30, 2025

  • Detect public pages and use appropriate endpoint (publicdicomjson vs dicomjson)
  • Add URL fallback for public page/token detection when DOM elements unavailable
  • Scan clicked subfolder instead of share root for DICOM files
  • Enable scanning files without proper DICOM MIME type (isOpenNoExtension)
  • Use WebDAV public endpoint instead of download redirect for file access

Fixes #108

@mgrosse66
Copy link
Copy Markdown

I tried your fix and now it is possible to open the dicomviewer within a public share but the dicomviewer cannot open the pictures.

/nextcloud/index.php/public.php/dav/files/8HrPcxsRzLfDNZ8/wetransfer_test-ct_2025-10-24_0908/Z160 HTTP/1.1" 404 7226

@loxK loxK force-pushed the fix-public-share branch from 855934a to 40bc71b Compare November 4, 2025 01:47
@loxK
Copy link
Copy Markdown
Author

loxK commented Nov 4, 2025

I tried your fix and now it is possible to open the dicomviewer within a public share but the dicomviewer cannot open the pictures.

It wasn't working with Nextcloud installations not using pretty URLs. I have modified my commit. Please retry.

@mgrosse66
Copy link
Copy Markdown

Thank you very much, now the dicomviewer works with public shares.

@github-actions github-actions bot added the stale This has no recent activity label Jan 4, 2026
@github-actions github-actions bot closed this Jan 12, 2026
@loxK loxK mentioned this pull request Feb 6, 2026
@JohnySeven
Copy link
Copy Markdown

@ayselafsar any comment on this PR? We would like to use your beautiful DICOM viewer to share DICOMS to our clients. But the viewer doesn't work when user is using NextCloud link only - no user is signed in.

Looks like this PR is fixing this issue.

Thank you for your time!
Jan

@ayselafsar ayselafsar reopened this Mar 30, 2026
@ayselafsar ayselafsar removed the stale This has no recent activity label Mar 30, 2026
@loxK loxK force-pushed the fix-public-share branch 4 times, most recently from 563efc7 to ced4369 Compare March 31, 2026 00:54
- Detect public pages and use appropriate endpoint (publicdicomjson vs dicomjson)
- Add URL fallback for public page/token detection when DOM elements unavailable
- Scan clicked subfolder instead of share root for DICOM files
- Enable scanning files without proper DICOM MIME type (isOpenNoExtension)
- Use WebDAV public endpoint instead of download redirect for file access

Fixes ayselafsar#108
@loxK loxK force-pushed the fix-public-share branch from ced4369 to 311512a Compare March 31, 2026 01:25
@dems54
Copy link
Copy Markdown

dems54 commented Apr 8, 2026

Would it be possible to include this PR in the next release ?

Does this also work for links shared via link or email with a password? (Because currently, just like with public shares, it doesn’t work.)

@JohnySeven
Copy link
Copy Markdown

Would it be possible to include this PR in the next release ?

Does this also work for links shared via link or email with a password? (Because currently, just like with public shares, it doesn’t work.)

I second that! Please make this working! Can I support development of this feature? Thanks!

@dems54
Copy link
Copy Markdown

dems54 commented Apr 8, 2026

Currently, when I try to open a DICOM file shared by email or link (with a password, which is mandatory on my instance), I get a 401 error on the call to https://dev.medicalcloud.fr/apps/dicomviewer/dicomjson?file=XXXX

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Open with DICOM Viewer not available for shared links in v2 on NC28

5 participants