Fix UTF-8 double encoding issue with accented characters#150
Open
loxK wants to merge 1 commit intoayselafsar:masterfrom
Open
Fix UTF-8 double encoding issue with accented characters#150loxK wants to merge 1 commit intoayselafsar:masterfrom
loxK wants to merge 1 commit intoayselafsar:masterfrom
Conversation
Closed
Replace utf8_encode() with mb_convert_encoding() and check if string is already UTF-8 before converting to avoid double encoding that causes 404 errors on paths with accented characters (e.g., 'Santé'). Fixes ayselafsar#119
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace utf8_encode() with mb_convert_encoding() and check if string is already UTF-8 before converting to avoid double encoding that causes 404 errors on paths with accented characters (e.g., 'Santé').
Fixes #119