[Storage] Implement IAsyncDisposable in StorageWriteStream (Azure#48628)

* Implemented DisposeAsync in StorageWriteStream * feedback
azure-sdk · Mar 7, 2025 · 1a90ea9 · 1a90ea9
1 parent 10ad7e3
commit 1a90ea9
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 0 deletions.
diff --git a/sdk/storage/Azure.Storage.Common/CHANGELOG.md b/sdk/storage/Azure.Storage.Common/CHANGELOG.md
@@ -13,6 +13,7 @@
 - Fixed bug where LazyLoadingReadOnlyStream overprovisions the default buffer memory for OpenRead
 
 ### Other Changes
+- Implemented IAsyncDisposable in StorageWriteStream
 
 ## 12.23.0-beta.1 (2025-02-11)
 

diff --git a/sdk/storage/Azure.Storage.Common/src/Shared/StorageWriteStream.cs b/sdk/storage/Azure.Storage.Common/src/Shared/StorageWriteStream.cs
@@ -346,6 +346,30 @@ protected override void Dispose(bool disposing)
             base.Dispose(disposing);
         }
 
+#if NETCOREAPP3_0_OR_GREATER || NETCORESTANDARD2_1_OR_GREATER
+        public override async ValueTask DisposeAsync()
+        {
+            if (_disposed)
+            {
+                return;
+            }
+
+            try
+            {
+                await FlushAsync(cancellationToken: default).ConfigureAwait(false);
+                ValidateCallerCrcIfAny();
+            }
+            finally
+            {
+                _accumulatedDisposables.Dispose();
+            }
+
+            _disposed = true;
+
+            await base.DisposeAsync().ConfigureAwait(false);
+        }
+#endif
+
         private void ValidateCallerCrcIfAny()
         {
             if (UseMasterCrc && !_userProvidedChecksum.IsEmpty)