Fix/ssr list hydration#1
Merged
babaygt merged 3 commits intoMar 31, 2026
Merged
Conversation
Also fix SSR todo example import paths (vite-plugin src/index.ts, CSS import).
Three changes fix SSR list hydration: 1. Add __adoptListItems() to Component: populates compiler-generated _*Items tracking arrays with adopted child components during hydration, so subsequent __reconcileList calls see existing items. 2. Silent restoreStoreState in hydrate(): discards pending change notifications from restoreStoreState since the DOM already reflects the server state and the tracking arrays aren't populated yet. 3. Clean up observers in renderToString: the dev-mode mismatch detection creates a temporary App instance whose constructor registers observers on shared stores. Without cleanup, these duplicate observers cause double reconciliation on every store change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue