Skip to content

[feat] Add Docker image publishing for easy adoption for everyone. - #37

Closed
marcelMaier wants to merge 1 commit into
baidu:mainfrom
marcelMaier:codex/docker-publishing
Closed

[feat] Add Docker image publishing for easy adoption for everyone.#37
marcelMaier wants to merge 1 commit into
baidu:mainfrom
marcelMaier:codex/docker-publishing

Conversation

@marcelMaier

@marcelMaier marcelMaier commented Jun 26, 2026

Copy link
Copy Markdown

Summary

  • Add a CUDA-based Docker image for the SGLang batch inference path in infer.py
  • Add a Docker Compose example for local NVIDIA GPU usage with mounted input, output, logs, and Hugging Face cache directories
  • Add a GitHub Actions workflow that builds Docker images for PRs and publishes on main, version tags, or manual runs
  • Document local Docker usage and the publishing secrets maintainers can configure

Publishing

The workflow publishes to GHCR with the built-in GITHUB_TOKEN. To also publish to Docker Hub, repository maintainers only need to add these repository secrets:

  • DOCKERHUB_USERNAME
  • DOCKERHUB_TOKEN

Validation

  • docker compose config
  • YAML parsed for .github/workflows/docker.yml and docker-compose.yml
  • Verified Docker Hub contains the selected nvidia/cuda:12.9.1-cudnn-devel-ubuntu24.04 base image tag

@rajpratham1 rajpratham1 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a comprehensive infrastructure improvement that adds first-class Docker support without changing the application's inference logic. The PR includes a Dockerfile, Docker Compose configuration, CI workflow for automatic image publishing, dependency management, ignore files, and documentation. Everything is scoped toward improving deployment and distribution rather than modifying runtime behavior.

@marcelMaier

Copy link
Copy Markdown
Author

This is a comprehensive infrastructure improvement that adds first-class Docker support without changing the application's inference logic. The PR includes a Dockerfile, Docker Compose configuration, CI workflow for automatic image publishing, dependency management, ignore files, and documentation. Everything is scoped toward improving deployment and distribution rather than modifying runtime behavior.

Yes that was the goal to make it easy to adopt for everyone without much work.
I think this could give the project a nice boost.

@marcelMaier marcelMaier changed the title [codex] Add Docker image publishing [feat] Add Docker image publishing for easy adoption for everyone. Jun 26, 2026
@marcelMaier

Copy link
Copy Markdown
Author

Superseded by #39.

@marcelMaier
marcelMaier deleted the codex/docker-publishing branch June 26, 2026 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants