Skip to content

Fix two unclosed-resource leaks on error/retry paths in infer.py #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nazarli-shabnam wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix two unclosed-resource leaks on error/retry paths in infer.py #64

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions infer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,7 @@ def start_server(args):
while time.time() - start < SERVER_TIMEOUT:
if process.poll() is not None:
log_file.flush()
log_file.close()
raise RuntimeError(f"SGLang server exited early. Check {args.server_log}")
if server_ready(SERVER_URL):
print(f"Server ready ({time.time() - start:.0f}s)")
Expand Down Expand Up @@ -212,6 +213,7 @@ def infer_one(image_path: str, output_file: str | None, args, idx: int) -> dict:
stream=True,
)
if resp.status_code == 502 and attempt < MAX_RETRIES - 1:
resp.close()
time.sleep(3 * (attempt + 1))
continue
resp.raise_for_status()
Expand Down