Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(kafka-connect-api): improve & speed up tests #618

Draft
wants to merge 59 commits into
base: main
Choose a base branch
from
Draft

test(kafka-connect-api): improve & speed up tests #618

wants to merge 59 commits into from

Conversation

disrupted
Copy link
Member

@disrupted disrupted commented Mar 20, 2025 •
edited
Loading

related to #274

disrupted added 30 commits March 6, 2025 16:20
@disrupted
feat(kafka-connector): add initial state option
457629c
@disrupted
feat(kafka-connect): send initial_state on connector create
f5a1268
@disrupted
test: use enum for HTTP response codes
e99d5f9
@disrupted
refactor(kafka-connect): remove None case for get connector
07d007f 
name should always be set
@disrupted
refactor(kafka-connect): set client base url
c346296
@disrupted
refactor(kafka-connect): set headers globally for client
2693420
@disrupted
test: update snapshots
f9b80e0
@disrupted
refactor(kafka-connect): use connector config Pydantic model for resp…
0ebd718 
…onse
@disrupted
refactor: use lower case initial state for user config
389a658
@disrupted
test: update Connect wrapper tests
2917688
@disrupted
docs: update description for initial state
afa8c29
@disrupted
test: update snapshots
2703187
@disrupted
test: update
59b6ae2
@disrupted
test: add test case for initial state paused & stopped
30cbafb
@disrupted
refactor(kafka-connect): make initial_state nullable
17be988
@disrupted
test: update snapshots
1ca0d13
@disrupted
feat(kafka-connect): set state on connector update
9074e74
@disrupted
test: update kafka connect handler tests
a375e84
@disrupted
refactor: adjust order
328cd4f
@disrupted
fix: resume connector after updating its config
a3a85be
@disrupted
docs: update param
bb2e2e4
@disrupted
docs: fix param
93878ad
@disrupted
fix(kafka-connect): handle API response correctly
cf099be
@disrupted
fix(kafka-connect): correctly raise exception when response body doesn't
cf49e99 
contain JSON
@disrupted
test(connect-wrapper): add tests
e6099b3
@disrupted
test: setup KPOps logger globally
6b0e0ee
@disrupted
test: refactor & assert log on state change
4417607
@disrupted
test(connect-wrapper): assert connector create without initial state
6a02ad1
@disrupted
feat: check actual connector state before update
f2d0817
@disrupted
feat(kafka-connect): log update state during dry-run
0bedbf0
disrupted added 24 commits March 18, 2025 16:05
@disrupted
test: use more narrow return type annotation for fixture
8971274
@disrupted
fix: apply feedback
9905eb7
@disrupted
fix: add connector failed state
ace7e83
@disrupted
fix: use correct HTTP status for connector stop
9e82002
@disrupted
refactor: always try resume connector if new state is running
2236196
@disrupted
refactor: do not expose connector state stopped
233d1d9
@disrupted
test: rename parameter for current connector state
fdfff0a
@disrupted
test: add failing test
f867ec3
@disrupted
fix: uppercase enum values
4d0ae1f
@disrupted
refactor: convert enum to API value
7bb363d
@disrupted
test: fix enum conversion
4838e7b
@disrupted
refactor: remove unnecessary logs
1d10a24
@disrupted
docs: add missing param docs
d77ddb5
@disrupted
fix: serialize JSON response in exception handler
2df04ce
@disrupted
fix: add missing return after retry
c5ee764 
exception was raised after retry even in the success case
@disrupted
test: refactor and speedup
ccb0ee0
@disrupted
test: update wrong test
f0bbc30
@disrupted
test: rename tests
06ebac5
@disrupted
test: rename and refactor tests
b5de7f9
@disrupted
test: speed up tests
64bef6c
@disrupted
test: use non-asyncio pytest fixture
ebc0286
@disrupted
test: refactor test
7074e78
@disrupted
refactor: use caplog fixture instead of custom mock for logs
88096e9
@disrupted
test: remove flaky decorator for Windows
f2a92ff 
problem should hopefully be fixed by using caplog
@disrupted disrupted added type/refactor Refactoring of existing functionality area/tests Relates to tests labels Mar 20, 2025
@disrupted disrupted self-assigned this Mar 20, 2025
@disrupted disrupted changed the base branch from main to feat/kafka-connect-initial-state March 20, 2025 16:34
Base automatically changed from feat/kafka-connect-initial-state to main March 20, 2025 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@disrupted disrupted

Labels
area/tests Relates to tests type/refactor Refactoring of existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace the way logs get mocked
1 participant
@disrupted