Fix issue #52: Handle AST variable opts in macros #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: When field options are passed as variables in macro contexts, they become AST variable references instead of literal keyword lists. The original code called Keyword.drop/2 directly on opts, which failed with FunctionClauseError when opts was an AST tuple. Solution: Check if opts is a compile-time keyword list using Keyword.keyword?/1. If yes, drop keys at compile time. If no (AST variable reference), generate code to drop keys at runtime. Changes: - Modified TypedEctoSchema.SyntaxSugar.transform_expression/2 to handle both compile-time keyword lists and runtime AST variable references - Added test case that reproduces the issue and verifies the fix - Added CLAUDE.md with development guidelines Fixes #52
Collaborator
Author
|
@bamorim ngl, this was 99.9% Claude ;) |
|
I tested this branch, and it compiles and passes tests (running our larger suite now). Thank you! |
Owner
|
@dvic who am I to say no to our master Claude??? |
bamorim
approved these changes
Jun 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #52 by properly handling field options when they are passed as variables in macro contexts.
Problem
When field options (
opts) are passed as variables in macro contexts, they become AST variable references (tuples like{:opts, [], Module}) instead of literal keyword lists. The original code insyntax_sugar.ex:46calledKeyword.drop/2directly onopts, which failed with aFunctionClauseErrorwhenoptswas an AST tuple.Solution
Modified
TypedEctoSchema.SyntaxSugar.transform_expression/2to:optsis a compile-time keyword list usingKeyword.keyword?/1Changes
lib/typed_ecto_schema/syntax_sugar.exto handle both compile-time and runtime optsCLAUDE.mdwith development guidelinesTest Plan
mix formatBackward Compatibility
✅ Fully backward compatible - existing usage with literal keyword lists works exactly as before, with the same compile-time optimization.