-
Notifications
You must be signed in to change notification settings - Fork 33
Filtering 3rd parties out of Sentry #1984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the final PR Bugbot will review for you during this billing cycle
Your free Bugbot reviews will reset on December 7
Details
Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
Deploying carbon-app-celo with
|
| Latest commit: |
80eef6b
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://6047f426.carbon-app-celo.pages.dev |
| Branch Preview URL: | https://sentry-filter.carbon-app-celo.pages.dev |
Deploying carbon-app with
|
| Latest commit: |
80eef6b
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://726eaa4c.carbon-app-csq.pages.dev |
| Branch Preview URL: | https://sentry-filter.carbon-app-csq.pages.dev |
Deploying carbon-app-sei with
|
| Latest commit: |
80eef6b
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://144d5b55.carbon-app-sei.pages.dev |
| Branch Preview URL: | https://sentry-filter.carbon-app-sei.pages.dev |
Deploying carbon-app-coti with
|
| Latest commit: |
80eef6b
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://59dd26c5.carbon-app-coti.pages.dev |
| Branch Preview URL: | https://sentry-filter.carbon-app-coti.pages.dev |
Deploying carbon-app-blast with
|
| Latest commit: |
80eef6b
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://29d391b9.carbon-app-blast.pages.dev |
| Branch Preview URL: | https://sentry-filter.carbon-app-blast.pages.dev |
Deploying carbon-app-tac with
|
| Latest commit: |
80eef6b
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://d438c9fa.carbon-app-tac.pages.dev |
| Branch Preview URL: | https://sentry-filter.carbon-app-tac.pages.dev |
Deploying carbon-app-ton-tg with
|
| Latest commit: |
80eef6b
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://89e65ccc.carbon-app-ton-tg.pages.dev |
| Branch Preview URL: | https://sentry-filter.carbon-app-ton-tg.pages.dev |
| project: env.SENTRY_PROJECT, | ||
| applicationKey: | ||
| env.VITE_SENTRY_APPLICATION_KEY || | ||
| 'custom_application_key_carbon_app', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Sentry Vite Plugin: Configuration Error Halts Error Filtering
The applicationKey parameter passed to sentryVitePlugin doesn't appear to be a valid configuration option for the Sentry Vite plugin. According to Sentry's documentation, bundler plugins use _experiments.moduleMetadata to inject metadata for third-party error filtering, not a top-level applicationKey parameter. This means the third-party error filtering configured in src/init-sentry.ts likely won't function correctly because the application key won't be properly embedded in the build output for Sentry to match against the filterKeys.
GrandSchtroumpf
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM
Note
Introduces Sentry third‑party error filtering using an application key, wired into both runtime init and the Vite Sentry plugin, with new env/type definitions.
thirdPartyErrorFilterIntegrationinsrc/init-sentry.tsto drop errors containing third‑party frames usingVITE_SENTRY_APPLICATION_KEY(fallback tocustom_application_key_carbon_app).applicationKeyto the Sentry Vite plugin invite.config.tsfromVITE_SENTRY_APPLICATION_KEY(with same fallback).VITE_SENTRY_APPLICATION_KEYto.env.sampleandImportMetaEnvinsrc/vite-env.d.ts.Written by Cursor Bugbot for commit 80eef6b. This will update automatically on new commits. Configure here.