[Tunnel] implement route - Axelar #574
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RogerKSI
requested changes
Feb 14, 2025
RogerKSI
reviewed
Feb 20, 2025
nkitlabs
reviewed
Apr 1, 2025
| // axelar_ibc_channel specifies the IBC channel used by the tunnel to communicate with the axelar chain. | ||
| string axelar_ibc_channel = 8 [(gogoproto.customname) = "AxelarIBCChannel"]; | ||
| // axelar_gmp_account is the account address on axelar chain that processes and verifies Axelar GMP transactions. | ||
| string axelar_gmp_account = 9; |
There was a problem hiding this comment.
should it be renamed to AxelarGMPAccount (based on the comment above)? If not neccesary, can be resolved.
| ) | ||
|
|
||
| var ( | ||
| packetABI, _ = abi.NewType("tuple", "", []abi.ArgumentMarshaling{ |
There was a problem hiding this comment.
this is for Axelar only or for the others (in the future) as well? b/c i see you rename tss part (to have tss prefix), should it be align?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation details
Integration test
Please ensure the following requirements are met before submitting a pull request:
CHANGELOG_UNRELEASED.mdFiles changedtab in the Github PR explorer)