Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: upgrade typescript to v5 #441

Merged
merged 9 commits into from
Mar 24, 2023
Merged

build: upgrade typescript to v5 #441

merged 9 commits into from
Mar 24, 2023

Conversation

trim21
Copy link
Contributor

@trim21 trim21 commented Mar 11, 2023

ts 5.0 没有 break change,不过有些打包工具没解决新版本 ts 的 deprecation warning,而且看起来 webstorm 的支持也有些问题。

唯一的新语法 Const Generics 一时半会也用不到(

有几个新的 tsconfig 选项倒是挺有意义,比如 "moduleResolution": "bundler""allowImportingTsExtensions": true"verbatimModuleSyntax": true

@github-actions
Copy link
Contributor

github-actions bot commented Mar 11, 2023

@codecov
Copy link

codecov bot commented Mar 11, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (efea556) 83.49% compared to head (bd2728a) 83.49%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #441   +/-   ##
=======================================
  Coverage   83.49%   83.49%           
=======================================
  Files          93       93           
  Lines        5375     5375           
  Branches      427      428    +1     
=======================================
  Hits         4488     4488           
  Misses        880      880           
  Partials        7        7           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@trim21 trim21 marked this pull request as draft March 11, 2023 17:48
@mergify
Copy link

mergify bot commented Mar 13, 2023

@trim21 this pull request is now in conflict 😩

@mergify mergify bot added the conflict label Mar 13, 2023
@mergify mergify bot removed the conflict label Mar 17, 2023
@trim21 trim21 marked this pull request as ready for review March 17, 2023 01:34
@mergify mergify bot added the waiting-approval waiting code reviewers to approval PR label Mar 17, 2023
Ayase-252
Ayase-252 previously approved these changes Mar 17, 2023
@mergify
Copy link

mergify bot commented Mar 19, 2023

@trim21 this pull request is now in conflict 😩

@mergify mergify bot added the conflict label Mar 19, 2023
@mergify
Copy link

mergify bot commented Mar 19, 2023

@trim21 this pull request is now in conflict 😩

@mergify mergify bot added the conflict label Mar 19, 2023
@mergify mergify bot removed the conflict label Mar 24, 2023
@mergify
Copy link

mergify bot commented Mar 24, 2023

@trim21 this pull request is now in conflict 😩

@mergify mergify bot added the conflict label Mar 24, 2023
@mergify mergify bot removed the conflict label Mar 24, 2023
@trim21
Copy link
Contributor Author

trim21 commented Mar 24, 2023

发现这个 deprecated warning 是 babel-plugin-lodash 的问题

lodash/babel-plugin-lodash#259

@trim21 trim21 merged commit 83aa169 into bangumi:master Mar 24, 2023
@trim21 trim21 deleted the ts-v5 branch May 6, 2023 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS waiting-approval waiting code reviewers to approval PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants