Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(select): select style #583

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Gypsophyllite
Copy link

Rewrite select component's style:

  1. change html select option into ul li
  2. replace select story's deprecated type
  3. add some style

@github-actions
Copy link
Contributor

github-actions bot commented May 18, 2023

Preview Deployment

Build URL time
Sites netlify preview 2023-04-05 04:49:40Z
Storybook netlify preview 2023-04-05 04:50:50Z

@mergify mergify bot added the ci:test:fail label May 18, 2023
@mergify mergify bot added waiting-approval waiting code reviewers to approval PR and removed ci:test:fail labels May 18, 2023
@cokemine
Copy link
Contributor

这个样式figma上没有吧

@y-young
Copy link
Contributor

y-young commented May 22, 2023

这样写的话点空白处无法关闭下拉框吧

</select>
{open ? (
<ul className={cn('bgm-select__dropdown')} defaultValue={defaultValue}>
{options.map((option) => (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

为啥要替换成 ul,感觉语义不太对?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S waiting-approval waiting code reviewers to approval PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants