-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(select): select style #583
Open
Gypsophyllite
wants to merge
2
commits into
bangumi:master
Choose a base branch
from
Gypsophyllite:feat/design-select
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Preview Deployment
|
Gypsophyllite
force-pushed
the
feat/design-select
branch
from
May 18, 2023 13:37
4e5d498
to
c73c8d8
Compare
mergify
bot
added
waiting-approval
waiting code reviewers to approval PR
and removed
ci:test:fail
labels
May 18, 2023
Gypsophyllite
force-pushed
the
feat/design-select
branch
from
May 19, 2023 01:31
c73c8d8
to
1355d3a
Compare
这个样式figma上没有吧 |
这样写的话点空白处无法关闭下拉框吧 |
Ayase-252
reviewed
May 22, 2023
</select> | ||
{open ? ( | ||
<ul className={cn('bgm-select__dropdown')} defaultValue={defaultValue}> | ||
{options.map((option) => ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
为啥要替换成 ul,感觉语义不太对?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewrite select component's style:
select
option
intoul
li
select
story's deprecated type