fix(pipe): fatal error with operators in template

bartholomej · Nov 23, 2021 · 1775dd8 · 1775dd8
1 parent 2761a9a
commit 1775dd8
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/src/parsers/pipe.parser.ts b/src/parsers/pipe.parser.ts
@@ -111,7 +111,9 @@ export class PipeParser implements ParserInterface {
 		// string concatenation, e.g.:
 		// - 'foo' + 'bar' + ('baz' | translate)
 		if (ast instanceof Binary) {
-			return this.getTranslatablesFromAsts([ast.left, ast.right]);
+			if (ast?.left && ast?.right) {
+				return this.getTranslatablesFromAsts([ast.left, ast.right]);
+			}
 		}
 
 		// a pipe on the outer expression, but not the translate pipe - ignore the pipe, visit the expression, e.g.:

diff --git a/tests/parsers/pipe.parser.spec.ts b/tests/parsers/pipe.parser.spec.ts
@@ -201,4 +201,12 @@ describe('PipeParser', () => {
 		const keys = parser.extract(contents, templateFilename).keys();
 		expect(keys).to.deep.equal([`Hello`, `World`]);
 	});
+
+	it('should not break extraction in this special case with operators in template', () => {
+		const contents = `
+			<div [class.active]="+variable === -variable.item2">Active</div>
+		`;
+		const keys = parser.extract(contents, templateFilename).keys();
+		expect(keys).to.deep.equal([]);
+	});
 });