chore/fix: Update gas limit from 264M -> 288M with new Base contracts #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Heimdall Review Status
|
0x00101010
reviewed
Jan 29, 2025
Comment on lines
11
to
12
| 1. `UpgradeGasLimit` -- This script will update the gas limit to our new limit of 288M gas | ||
| 2. `RollbackGasLimit` -- This script establishes a rollback call in the case we need to revert to gas |
There was a problem hiding this comment.
nit: do we want to update README as well, or maybe the template?
0x00101010
force-pushed
the
brianbland/gas-bump-01-29-fix
branch
from
66e5088 to
072e611
Compare
jackchuma
reviewed
Feb 12, 2025
jackchuma
approved these changes
Feb 12, 2025
xenoliss
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revises #260 to fix pre-signing of the rollback transaction.
Updates Base contracts commit to
cdedd0fe728eb1f9d63eaa4c6e59138cfb3803d3, using only a singleSetGasLimitcontract instead ofUpgradeGasLimitandRollbackGasLimit.