-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set up fault proof upgrade scripts #267
Conversation
✅ Heimdall Review Status
|
BASE_CONTRACTS_COMMIT=cdedd0fe728eb1f9d63eaa4c6e59138cfb3803d3 | ||
|
||
SYSTEM_CONFIG=0xf272670eb55e895584501d564AfEB048bEd26194 | ||
ABSOLUTE_PRESTATE=0x035ac388b5cb22acf52a2063cfde108d09b1888655d21f02f595f9c3ea6cbdcd |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Retrieved from this file for 1.5.0-rc.2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks right.
It's also in our challenger PR.
import {FaultDisputeGame} from "@eth-optimism-bedrock/src/dispute/FaultDisputeGame.sol"; | ||
import {PermissionedDisputeGame} from "@eth-optimism-bedrock/src/dispute/PermissionedDisputeGame.sol"; | ||
|
||
contract UpgradeDGF is MultisigBuilder { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using MultisigBuilder
since our Sepolia setup does not use nested multisigs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Seems like we may be doing more of this in the future. Not sure if it's worth templating, but maybe we can consider.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few nits, overall looks good to me.
Also consider fixing the inconsistency in the comments (sometimes using @notice
, sometimes @dev
and sometimes nothing).
sepolia/2025-02-14-upgrade-fault-proofs/script/UpgradeDGF.s.sol
Outdated
Show resolved
Hide resolved
sepolia/2025-02-14-upgrade-fault-proofs/script/UpgradeDGF.s.sol
Outdated
Show resolved
Hide resolved
sepolia/2025-02-14-upgrade-fault-proofs/script/UpgradeDGF.s.sol
Outdated
Show resolved
Hide resolved
Approved review 2621391411 from cbfyi is now dismissed due to new commit. Re-request for approval.
We will need to upgrade our fault proof contracts to reference an updated absolute prestate to prepare for the Ethereum Pectra hard fork. For more information, see https://docs.optimism.io/notices/pectra-changes