Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up fault proof upgrade scripts #267

Merged
merged 3 commits into from
Feb 18, 2025
Merged

Conversation

jackchuma
Copy link
Contributor

We will need to upgrade our fault proof contracts to reference an updated absolute prestate to prepare for the Ethereum Pectra hard fork. For more information, see https://docs.optimism.io/notices/pectra-changes

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Feb 15, 2025

✅ Heimdall Review Status

Requirement Status More Info
Reviews 2/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

BASE_CONTRACTS_COMMIT=cdedd0fe728eb1f9d63eaa4c6e59138cfb3803d3

SYSTEM_CONFIG=0xf272670eb55e895584501d564AfEB048bEd26194
ABSOLUTE_PRESTATE=0x035ac388b5cb22acf52a2063cfde108d09b1888655d21f02f595f9c3ea6cbdcd
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Retrieved from this file for 1.5.0-rc.2

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks right.

It's also in our challenger PR.

import {FaultDisputeGame} from "@eth-optimism-bedrock/src/dispute/FaultDisputeGame.sol";
import {PermissionedDisputeGame} from "@eth-optimism-bedrock/src/dispute/PermissionedDisputeGame.sol";

contract UpgradeDGF is MultisigBuilder {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using MultisigBuilder since our Sepolia setup does not use nested multisigs

cbfyi
cbfyi previously approved these changes Feb 17, 2025
Copy link

@cbfyi cbfyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Seems like we may be doing more of this in the future. Not sure if it's worth templating, but maybe we can consider.

Copy link
Contributor

@xenoliss xenoliss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few nits, overall looks good to me.

Also consider fixing the inconsistency in the comments (sometimes using @notice, sometimes @dev and sometimes nothing).

@cb-heimdall cb-heimdall dismissed cbfyi’s stale review February 18, 2025 16:25

Approved review 2621391411 from cbfyi is now dismissed due to new commit. Re-request for approval.

@jackchuma jackchuma requested review from xenoliss and cbfyi February 18, 2025 16:25
@jackchuma jackchuma merged commit df1f376 into main Feb 18, 2025
3 checks passed
@jackchuma jackchuma deleted the jack/upgrade-fault-proofs branch February 18, 2025 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants