update Funding Template to enable simulation signing #431
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…k for non-members of the Safe
🟡 Heimdall Review Status
|
danyalprout
previously approved these changes
Oct 13, 2025
meyer9
approved these changes
Oct 13, 2025
|
Review Error for meyer9 @ 2025-10-13 21:53:54 UTC |
jackchuma
reviewed
Oct 14, 2025
cb-heimdall
dismissed
danyalprout’s stale review
Approved review 3333055354 from danyalprout is now dismissed due to new commit. Re-request for approval.
tobidae-cb
approved these changes
Oct 17, 2025
jackchuma
reviewed
Oct 17, 2025
|
|
||
| .PHONY: sign | ||
| sign: | ||
| $(call MULTISIG_SIGN,) |
There was a problem hiding this comment.
Can this just be $(call MULTISIG_SIGN,) --sender $(SENDER) ?
There was a problem hiding this comment.
Alternatively can just add the --sender flag to the underlying Makefile.mk file that this is using
jackchuma
reviewed
Oct 17, 2025
| @@ -1,3 +1,5 @@ | |||
| SENDER= # Any address that is a current owner of the Safe can be used for similation | |||
There was a problem hiding this comment.
Suggested change
| SENDER= # Any address that is a current owner of the Safe can be used for similation | |
| SENDER= # Any address that is a current owner of the Safe can be used for simulation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR updates the Funding Template's
Makefilein order to make signing simulation work for non-members of the given Safe.