Skip to content

Conversation

@mur-me
Copy link

@mur-me mur-me commented Nov 11, 2025

During my flashblocks setup I've noticed this small issue, this extra header for curl fixes it

@cb-heimdall
Copy link
Collaborator

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

Copy link

@mslord213 mslord213 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good — adding the Content-Type: application/json header makes the example conformant with JSON-RPC and avoids potential 415 errors from stricter servers.

One minor thought: if there are other curl JSON-RPC examples in the docs, it might be worth checking they also include the header so that users get consistent guidance. Otherwise this change looks solid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants