Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update OnchainKit contribution docs #2171

Merged
merged 5 commits into from
Apr 7, 2025

Conversation

dgca
Copy link
Contributor

@dgca dgca commented Apr 6, 2025

What changed? Why?

Updated onchainkit/guides/contribution.mdx to reflect new project structure.

Link to preview 🔗

Notes to reviewers

How has it been tested?

Have you tested the following pages?

BaseWeb

  • base.org
  • base.org/names
  • base.org/builders
  • base.org/ecosystem
  • base.org/name/jesse
  • base.org/manage-names
  • base.org/resources

BaseDocs

  • docs.base.org
  • docs sub-pages

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Apr 6, 2025

✅ Heimdall Review Status

Requirement Status More Info
Reviews 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

Copy link

vercel bot commented Apr 6, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
base-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 7, 2025 4:47pm
web-base-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 7, 2025 4:47pm

```
// @noErrors: 2304 - Cannot find name
```bash
pnpm f:ock dev
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not pnpm f:play dev?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

### Updating changelog

To update the change log, run:

```bash
yarn changeset
pnpm changeset
```

Select `minor` and use the following format for the summary:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we mention semver here, i.e. pick change type based on semver?

@cb-heimdall
Copy link
Collaborator

Review Error for alessey @ 2025-04-07 16:47:11 UTC
User failed mfa authentication, public email is not set on your github profile. see go/mfa-help

@cb-heimdall
Copy link
Collaborator

Review Error for alessey @ 2025-04-07 16:47:40 UTC
User failed mfa authentication, public email is not set on your github profile. see go/mfa-help

@cb-heimdall
Copy link
Collaborator

Review Error for alessey @ 2025-04-07 16:52:01 UTC
User failed mfa authentication, public email is not set on your github profile. see go/mfa-help

@dgca dgca merged commit e273820 into master Apr 7, 2025
9 checks passed
@dgca dgca deleted the danc/update-onchainkit-contribution-docs branch April 7, 2025 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants