Repository navigation
Protect /workspace at the edge, add auth-guard regression tests, reproducible installs - #39
Merged
Merged
Conversation
The edge proxy protected dashboard/submit/etc. but not /workspace, the main authenticated area, leaving it to per-page guards alone. Add it to the protected prefixes and add regression tests covering the proxy list, every workspace page guard and the mutating server actions. Also add the missing .gitignore so dependencies, build output and env files can never be staged, and commit pnpm-lock.yaml so installs are reproducible. Includes framework-generated tsconfig/next-env updates and the bashar skill definition. 🤖 Generated with Codebuff Co-Authored-By: Codebuff <noreply@codebuff.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The edge proxy (apps/web/src/proxy.ts) rejected unauthenticated requests for dashboard, submit, onboarding and friends, but not /workspace - the entire authenticated transaction workspace. Every /workspace page happened to carry its own guard, so nothing was exposed today, but any new workspace route added without a guard would have been served unauthenticated at the edge. The repo also had no .gitignore, so dependencies, build output and future secret files were stageable, and no committed lockfile, so installs were not reproducible.
What changed
Verification
Generated with Codebuff
Co-Authored-By: Codebuff noreply@codebuff.com