Skip to content

fix(chat): action buttons hidden under next turn sticky header #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bashrusakh wants to merge 1 commit into from
Closed

fix(chat): action buttons hidden under next turn sticky header #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/ui/src/components/chat/components/TurnAssistantBlock.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ interface TurnAssistantBlockProps {

const TurnAssistantBlock: React.FC<TurnAssistantBlockProps> = ({ assistantMessages, renderMessage }) => {
return (
<div className="relative z-0">
<div className="relative">
{assistantMessages.map((message) => renderMessage(message))}
</div>
);
Expand Down
2 changes: 1 addition & 1 deletion packages/ui/src/components/chat/components/TurnItem.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ const TurnItem: React.FC<TurnItemProps> = ({ turn, stickyUserHeader = true, rend
data-scroll-spy-id={turn.turnId}
>
{stickyUserHeader ? (
<div className="sticky top-0 z-20 relative bg-[var(--surface-background)] [overflow-anchor:none]">
<div className="sticky top-0 z-20 bg-[var(--surface-background)] [overflow-anchor:none]">
<div className="relative z-10">
{renderMessage(turn.userMessage)}
</div>
Expand Down
6 changes: 3 additions & 3 deletions packages/ui/src/components/chat/message/MessageBody.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1740,7 +1740,7 @@ const AssistantMessageBody = React.memo(({
);
if (shouldShowStandaloneMessageActions && i === lastRenderableTextPartIndex) {
rendered.push(
<div key={`message-actions-${messageId}`} className={INLINE_MESSAGE_ACTIONS_CLASS_NAME} data-message-actions="true">
<div key={`message-actions-${messageId}`} className={cn(INLINE_MESSAGE_ACTIONS_CLASS_NAME, 'relative z-30')} data-message-actions="true">
<div className="flex items-center gap-1.5" data-message-action-group="true">
{messageActionButtons}
</div>
Expand Down Expand Up @@ -2061,15 +2061,15 @@ const AssistantMessageBody = React.memo(({
</div>
<MessageFilesDisplay files={parts} onShowPopup={onShowPopup} />
{shouldRenderStandaloneActionsAfterContent && (
<div className={INLINE_MESSAGE_ACTIONS_CLASS_NAME} data-message-actions="true">
<div className={cn(INLINE_MESSAGE_ACTIONS_CLASS_NAME, 'relative z-30')} data-message-actions="true">
<div className="flex items-center gap-1.5" data-message-action-group="true">
{messageActionButtons}
</div>
</div>
)}
{shouldShowTurnFooter && (
<div
className="mt-2 mb-1 flex flex-wrap items-center justify-start gap-1.5"
className="mt-2 mb-1 flex flex-wrap items-center justify-start gap-1.5 relative z-30"
style={MESSAGE_FOOTER_CONTAINER_STYLE}
>
<div className="flex items-center gap-1.5" data-message-action-group="true">
Expand Down