Skip to content

Add empty queryable cuda_runtime target for disabled cuda #405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add empty queryable cuda_runtime target for disabled cuda #405

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a8ce9f6
Add empty `cuda_runtime` target for disabled cuda
lalten Oct 24, 2025
8c85067
udpate integration tests
lalten Oct 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions cuda/private/templates/BUILD.cuda_disabled
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,3 +13,7 @@ filegroup(
name = "compiler_deps",
srcs = [],
)

cc_library(
name = "cuda_runtime",
)
12 changes: 5 additions & 7 deletions tests/integration/test_all.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,15 +26,13 @@ pushd "$this_dir/toolchain_none"
ERR=$(bazel build //:optinally_use_rule --@rules_cuda//cuda:enable=True 2>&1 || true)
if ! [[ $ERR == *"didn't satisfy constraint"*"valid_toolchain_is_configured"* ]]; then exit 1; fi

# use library fails because the library file does not exist
ERR=$(bazel build //:use_library 2>&1 || true)
if ! [[ $ERR =~ "target 'cuda_runtime' not declared in package" ]]; then exit 1; fi
if ! [[ $ERR =~ "ERROR: Analysis of target '//:use_library' failed" ]]; then exit 1; fi
# use library should analyse build successfully (empty cuda_runtime target exists)
bazel build //:use_library

# use rule fails because rules_cuda depends non-existent cuda toolkit
# use rule analyses correctly but fails during compilation because nvcc doesn't exist
ERR=$(bazel build //:use_rule 2>&1 || true)
if ! [[ $ERR =~ "target 'cuda_runtime' not declared in package" ]]; then exit 1; fi
if ! [[ $ERR =~ "ERROR: Analysis of target '//:use_rule' failed" ]]; then exit 1; fi
if ! [[ $ERR =~ "No such file or directory" ]]; then exit 1; fi
if ! [[ $ERR =~ "ERROR: Build did NOT complete successfully" ]]; then exit 1; fi

bazel clean && bazel shutdown
popd
Expand Down
Loading