Added non-conflicting hash for install files #1454
Conversation
| ] | ||
| }, | ||
| "repositories": { | ||
| "https://repo1.maven.org/maven2/": [ |
There was a problem hiding this comment.
This also happens on master when repining.
Caused by Map<String, Set<String>> repos = new LinkedHashMap<>(); in lock file class.
|
This is looking really good. I like the idea of only having conflicts if the transitive deps have changed. |
| for (String key : keys) { | ||
| toHash.put(key, rendered.get(key)); | ||
| @SuppressWarnings("unchecked") | ||
| private static Map<String, Integer> calculateArtifactHash(Map<String, Object> rendered) { |
There was a problem hiding this comment.
@shs96c question for a potential breaking change in the next major update.
It seems like this code and the code in v3_lock_file.bzl are similar. IIRC, the reason the starlark implementation exists is if the user doesn't have a lockfile.
If that is the case, is there a possibility to consolidate around the java code (which is easiest to test tbh) by forcing lockfile usage?
|
@MarconZet, I'm waiting until you move this out of draft before reviewing. Please LMK when you're ready! |
3 participants
No description provided.