-
-
Notifications
You must be signed in to change notification settings - Fork 597
refactor(gazelle) Types for exposed members of python.ParserOutput
are now all public
#2959
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
allows other py extensions to leverage the Python resolver logic
Can you elaborate on what these extensions are or might be?
TBH I'm hesitant to make any more of the gazelle go code truly public. I already am not a fan of the existing public items haha.
I'm hesitant because we don't have many maintainers for the gazelle stuff, and adding more public things means that changes need to be more careful.
I'll defer to @aignas on this, but otherwise the code changes are mostly fine. It's a very mechanical change.
@dougthor42 There may be gazelle extensions that generate other macros that have python dependencies and requires resolving Python imports. |
python.ParserOutput
are now all public
@aignas Yes good point, just update to make them all public. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merge conflict but otherwise LGTM.
Update Update Update cchangelog Update struct
Export the members of
python.ParserOutput
struct to make it publicly accessible. This allows otherpy
extensions to leverage the Python resolver logic for resolving Python imports, instead of have to duplicate the resolving logic.