fix: Fix bazel vendor support for requirements with environment markers #2997
+23
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes `bazel vendor` support for requirements files that contain environment markers. During a vendored `bazel build`, when evaluate_markers_py() is run it needs PYTHONHOME set to properly find the home of the vendored libraries. Resolves (bazel-contrib#2996)
armandomontanez
requested review from
rickeylev,
aignas and
groodt
as code owners
aignas
reviewed
Jun 17, 2025
| @@ -95,6 +97,7 @@ def evaluate_markers_py(mrctx, *, requirements, python_interpreter, python_inter | |||
| Label("@pypi__packaging//:BUILD.bazel"), | |||
| Label("//:BUILD.bazel"), | |||
| ], | |||
| "PYTHONHOME": str(interpreter.dirname), | |||
Done.
Ah, didn't realize that. Verified the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
bazel vendorsupport for requirements files that contain environment markers. During a vendoredbazel build, when evaluate_markers_py() is run it needs PYTHONHOME set to properly find the home of the vendored libraries.Resolves (#2996)