fix(pypi): correctly handle custom names in pipstar platforms #3054
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before it seems that we were relying on particular names in the pipstar platforms. This ensures that we rely on this less. Whilst at it fix a few typos and improve the formatting of the code. Work towards bazel-contrib#2949 Work towards bazel-contrib#2747
|
The |
rickeylev
approved these changes
Jul 6, 2025
python/private/pypi/extension.bzl
Outdated
| @@ -383,6 +387,12 @@ def _configure(config, *, platform, os_name, arch_name, config_settings, env = { | |||
| if key not in _SUPPORTED_PEP508_KEYS: | |||
| fail("Unsupported key in the PEP508 environment: {}".format(key)) | |||
|
|
|||
| if not os_name: | |||
| fail("'os_name' is required") | |||
There was a problem hiding this comment.
Were os_name and arch_name effectively required before, or is this new? Though, I think this pip.defaults API is still experimental, right?
There was a problem hiding this comment.
This is new. It is experimental, but I've been dragging some of the hidden constants from various parts of the PyPI code into the internally defined pip.default instances. This has been really useful in that sense. I think maybe I want to revert this requirement. It is not going to be compatible with the builder pattern.
aignas
commented
Jul 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before it seems that we were relying on particular names in the pipstar
platforms. This ensures that we rely on this less. Whilst at it fix a
few typos and improve the formatting of the code.
Work towards #2949
Work towards #2747