build: Fix pre-commit hooks + run in CI #3073
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonchinn178
requested review from
rickeylev,
aignas,
groodt and
dougthor42
as code owners
brandonchinn178
force-pushed
the
bchinn-pre-commit
branch
from
4462695 to
2beb2ad
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
@rickeylev Not sure why CI failed |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 11, 2025
pre-commit hooks were failing on `main`; presumably some developer didn't have pre-commit hooks set up locally or committed with `--no-verify`, and since it's not validated in CI, it got merged. Runs all pre-commit hooks in CI + fixes issues. Removes the buildifier job from CI since it's now covered by the pre-commit job **Question**: `update-deleted-packages` is showing different results locally on Mac vs in GitHub Actions. Not sure why... --------- Co-authored-by: Brandon Chinn <[email protected]>
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
brandonchinn178
force-pushed
the
bchinn-pre-commit
branch
from
2beb2ad to
e57908b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pre-commit hooks were failing on
main; presumably some developer didn't have pre-commit hooks set up locally or committed with--no-verify, and since it's not validated in CI, it got merged.Runs all pre-commit hooks in CI + fixes issues. Removes the buildifier job from CI since it's now covered by the pre-commit job
Question:
update-deleted-packagesis showing different results locally on Mac vs in GitHub Actions. Not sure why...