-
-
Notifications
You must be signed in to change notification settings - Fork 630
docs: add example for a complex multi-platform pypi configuration #3292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add example for a complex multi-platform pypi configuration #3292
Conversation
Summary of ChangesHello @rickeylev, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a crucial new documentation guide aimed at simplifying the management of multi-platform PyPI dependencies within a Bazel build environment using Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds a new how-to guide for managing multi-platform PyPI dependencies. The guide is well-structured and provides a good example. I've found a few typos and a broken command in a code snippet. Addressing these will improve the clarity and correctness of the documentation.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
…/rules_python into docs.multi.pip.example
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but please link to this from pip.parse
docs and from the existing pypi
documentation so that users have a better chance to discover this.
Done |
…into docs.multi.pip.example
) The core PyPI docs and API reference docs have the basics for setting up a multi-platform Bazel build, but there's a lot of cross-referencing and reading between the lines necessary. Create a how to guide specifically on how to do it to better explain the nuances. --------- Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
The core PyPI docs and API reference docs have the basics for setting up a multi-platform
Bazel build, but there's a lot of cross-referencing and reading between the lines necessary.
Create a how to guide specifically on how to do it to better explain the nuances.