Fix some behaviortree_cpp issues#6151
Conversation
|
Hello @kgreenek, modules you maintain (behaviortree_cpp) have been updated in this PR. |
|
@bazel-io skip_check unstable_url |
bazel-io
added
the
skip-url-stability-check
|
@meteorcloudy could you please trigger CI? |
meteorcloudy
added
the
presubmit-auto-run
|
@bazel-io skip_check incompatible_flags |
bazel-io
added
the
skip-incompatible-flags-test
|
@kgreenek ptal |
| "include/**/*.h", | ||
| "include/**/*.hpp", | ||
| ]), | ||
| # IMPORTANT: module_version() MUST be in the form of X.Y.Z |
There was a problem hiding this comment.
Is this comment important? I can't remember the exact reason I added it, but I remember there is some code that assumes the version is "X.X.X". Not sure what happens with that code now that there is a .bcr.X suffix. Would be worth looking into to understand / make sure something sane happens.
There was a problem hiding this comment.
I noticed it and did check: the code will try to split the string on . and then assume major.minor.patch
However it doesn't look at anything after the third field so adding a .bcr.1 suffix does not break it. The effect is that the version string is the same as the bazel module (4.7.0.bcr.1), but the version number continues to be 470.
bazel-io
left a comment
bazel-io
left a comment
There was a problem hiding this comment.
All modules in this PR have been approved by their maintainers. This PR will be merged if all presubmit checks pass.
bazel-io
added
the
auto-merged
To be able to compile behaviortree_cpp we need to * Update ncurses to bazelbuild#6149 * Update zmq to bazelbuild#6150 * Patch BehaviorTree/BehaviorTree.CPP#1020
4 participants
To be able to compile behaviortree_cpp we need to
-w#6150curses.hinstead ofncurses.hBehaviorTree/BehaviorTree.CPP#1020