Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support rules map_kind in go and proto languages #1870

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

lbcjbb
Copy link
Contributor

@lbcjbb lbcjbb commented Aug 16, 2024

What type of PR is this?

Bug fix

What package or component does this PR mostly affect?

  • language/go
  • language/proto

What does this PR do? Why is it needed?

This PR takes into account the rule mapping defined with the # gazelle:map_kind instructions for all Go and Proto rules.

Copy link
Collaborator

@fmeum fmeum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a test case?

This new package internal/mapkind will be used by tests of go and proto
languages to ensure all rules mapping are well taken into account.
@lbcjbb
Copy link
Contributor Author

lbcjbb commented Aug 24, 2024

I've added some tests, but I needed to move the map_kind logic from //cmd/gazelle to a new shareable internal package (9e4702a), to be used in go and proto languages tests (8a8d69a).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants