Improved BlazeTargetFilter regex to match more target names (#6021)

Changed the regex used by BlazeTargetFilter to include more valid target names based on https://bazel.build/concepts/labels#target-names
bazelbuild · Feb 12, 2024 · 8a82231 · 8a82231
1 parent 86ce82c
commit 8a82231
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/base/src/com/google/idea/blaze/base/run/filter/BlazeTargetFilter.java b/base/src/com/google/idea/blaze/base/run/filter/BlazeTargetFilter.java
@@ -40,9 +40,9 @@
 /** Parse blaze targets in streamed output. */
 public class BlazeTargetFilter implements Filter {
 
-  // See Bazel's LabelValidator class. Whitespace character intentionally not included here.
-  private static final String PACKAGE_NAME_CHARS = "a-zA-Z0-9/\\-\\._$()";
-  private static final String TARGET_CHARS = "a-zA-Z0-9+,=~#()$_@\\-/";
+  // See Bazel's LabelValidator class. Whitespace character and ' intentionally not included here.
+  private static final String PACKAGE_NAME_CHARS = "a-zA-Z0-9/\\-\\._$()@";
+  private static final String TARGET_CHARS = "a-zA-Z0-9!%@^_\"#$&()*\\-+,;<=>?\\[\\]{|}~/\\.";
 
   // ignore '//' preceded by text (e.g. https://...)
   // format: ([@external_workspace]//package:rule)

diff --git a/base/tests/unittests/com/google/idea/blaze/base/run/filter/BlazeTargetFilterTest.java b/base/tests/unittests/com/google/idea/blaze/base/run/filter/BlazeTargetFilterTest.java
@@ -48,8 +48,8 @@ public void testQuotedTarget() {
 
   @Test
   public void testUnusualCharsInTarget() {
-    String line = "Something //Package-._$():T0+,=~#target_@name something else";
-    assertThat(findMatch(line)).isEqualTo("//Package-._$():T0+,=~#target_@name");
+    String line = "Something //Package-._$()@:T0!%^_\"#$&()*-+,;<=>?[]{|}~/.target_@name something else";
+    assertThat(findMatch(line)).isEqualTo("//Package-._$()@:T0!%^_\"#$&()*-+,;<=>?[]{|}~/.target_@name");
   }
 
   @Test