Proper check for git repository

bazelbuild · Aug 8, 2023 · 9339783 · 9339783
1 parent b322d9e
commit 9339783
Showing 1 changed file with 5 additions and 4 deletions.
diff --git a/base/src/com/google/idea/blaze/base/vcs/git/GitBlazeVcsHandlerProvider.java b/base/src/com/google/idea/blaze/base/vcs/git/GitBlazeVcsHandlerProvider.java
@@ -125,10 +125,11 @@ private static String getGitUpstreamContent(WorkspaceRoot workspaceRoot, Workspa
   }
 
   private static boolean isGitRepository(WorkspaceRoot workspaceRoot) {
-    // TODO: What if the git repo root is a parent directory of the workspace root?
-    // Just call 'git rev-parse --is-inside-work-tree' or similar instead?
-    File gitDir = new File(workspaceRoot.directory(), ".git");
-    return FileOperationProvider.getInstance().isDirectory(gitDir);
+    ByteArrayOutputStream stdout = new ByteArrayOutputStream();
+
+    String[] args = new String[] {"git", "rev-parse", "--is-inside-work-tree"};
+    int retVal = ExternalTask.builder(workspaceRoot).args(args).stdout(stdout).build().run();
+    return retVal == 0 && "true".equals(StringUtil.trimEnd(stdout.toString(), "\n"));
   }
 
   /**