Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

- Allow to suppress automatic Bazel project opening if .ijwb or so … #5208

Merged

Conversation

dkashyn-sfdc
Copy link
Contributor

@dkashyn-sfdc dkashyn-sfdc commented Aug 7, 2023

…already exists by setting bazel.project.auto.open.if.present to false

  • Avoid activation of Bazel project auto import if .ijwb or other model that corresponds to current Bazel project mode is present.

Checklist

  • I have filed an issue about this change and discussed potential changes with the maintainers.
  • I have received the approval from the maintainers to make this change.
  • This is not a stylistic, refactoring, or cleanup change.

Please note that the maintainers will not be reviewing this change until all checkboxes are ticked. See
the Contributions section in the README for more
details.

Discussion thread for this change

Issue number: <please reference the issue number or url here>

Description of this change

Currently, if there is .ijwb present Bazel plugin instructs IJ to open project and ignore the rest of models. This is happening because the very first ProjectOpenProcessor#isStrongProjectInfoHolder is a winner and used to open the project.
Registry key is introduced to have more control over Bazel project opening, and to allow to yield to other project models if they known(to the person who disbled Bazel default behavior) to be present.

Bazel has 2 project openers and there is also a change to not activate auto import if the model already present.

…already exists by setting `bazel.project.auto.open.if.present` to `false`

- Avoid activation of Bazel project auto import if `.ijwb` or other model that corresponds to current Bazel project mode is present.
@github-actions github-actions bot added product: Android Studio Android Studio plugin product: CLion CLion plugin product: IntelliJ IntelliJ plugin product: GoLand GoLand plugin awaiting-review Awaiting review from Bazel team on PRs labels Aug 7, 2023
@tpasternak tpasternak merged commit a59b768 into bazelbuild:master Aug 11, 2023
6 checks passed
@github-actions github-actions bot removed the awaiting-review Awaiting review from Bazel team on PRs label Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product: Android Studio Android Studio plugin product: CLion CLion plugin product: GoLand GoLand plugin product: IntelliJ IntelliJ plugin
Projects
Development

Successfully merging this pull request may close these issues.

3 participants