Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for 2023.3: Use var to handle return type differences #5391

Merged

Conversation

tpasternak
Copy link
Collaborator

In 2023.2, kotlinFacet.getConfiguration().getSettings() returns KotlinFacetSetttings, while in 2023.3 it's IKotlinFacetSettings

JetBrains/intellij-community@f0094db

Checklist

  • I have filed an issue about this change and discussed potential changes with the maintainers.
  • I have received the approval from the maintainers to make this change.
  • This is not a stylistic, refactoring, or cleanup change.

Please note that the maintainers will not be reviewing this change until all checkboxes are ticked. See
the Contributions section in the README for more
details.

Discussion thread for this change

Issue number: <please reference the issue number or url here>

Description of this change

In 2023.2, kotlinFacet.getConfiguration().getSettings() returns
KotlinFacetSetttings, while in 2023.3 it's IKotlinFacetSettings

JetBrains/intellij-community@f0094db
@github-actions github-actions bot added product: IntelliJ IntelliJ plugin awaiting-review Awaiting review from Bazel team on PRs labels Sep 26, 2023
@agluszak
Copy link
Collaborator

that's smart

@tpasternak
Copy link
Collaborator Author

@mai93 please only confirm I can use var - it's java 11 feature. Otherwise I would have to prepare sdkcompat for that

@tpasternak
Copy link
Collaborator Author

Ok, we can revert it if needed

@tpasternak tpasternak merged commit 48deab1 into bazelbuild:master Sep 27, 2023
8 checks passed
@tpasternak tpasternak deleted the use-var-to-handle-type-differences branch September 27, 2023 07:23
@github-actions github-actions bot removed the awaiting-review Awaiting review from Bazel team on PRs label Sep 27, 2023
@mai93
Copy link
Collaborator

mai93 commented Sep 27, 2023

After 6f61904 we can use java 17 features except in aspect tools, they still require java 8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product: IntelliJ IntelliJ plugin
Projects
Development

Successfully merging this pull request may close these issues.

3 participants